Design comparison
SolutionDesign
Solution retrospective
Will be glad to hear your suggestions for changes that I can make in this :)
Community feedback
- @tesla-ambassadorPosted about 3 years ago
Hey, this is awesome work. I like that you used your own stars! I just have a few things I can add.
- I think you should try to use media queries to make your website responsive. I didn't see any in your CSS. But worry not, you can learn those at "https://youtu.be/Xig7NsIE6DI" I hope it's of use. (I low-key think you might have forgotten to add them... if that's the case well,π )
- You didn't have any html issues, it's just the accessibility. You should contain your elements in landmarks like sections, articles... etc. So that it's helpful to those who use screen readers.
- Also you can only have on main landmark, consider using a section or article if you want to use another landmark. Otherwise, thanks for this awesome solution. Kudos! Keep on coding!
Marked as helpful2 - @guztrilloPosted about 3 years ago
Hi Abhishek, avoid using
position: absolute
and try Flexbox and CSS Grid instead. It will be easier to make the design responsive.Marked as helpful1 - @vikrantmallaPosted about 3 years ago
Try to add a grid in the user div It makes easier to position 3 divs and add media queries.
Marked as helpful1 - Account deleted
You must make it responsive because it doesn't work for almost every width, when you resize things just get on top of each other.
Marked as helpful1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord