Design comparison
Community feedback
- @correlucasPosted about 2 years ago
👾Hello @itadori-kun, congratulations on your new solution!
I’ve some suggestions for you:
1.When you download the project files there’s a file called
style-guide.md
where you can find information such asfont-family
,hsl color codes
, device sizes, and thefont-size
for the headings.2.You’re in the right track I can see that you’ve used the majority semantic tags possible for this challenge, the only block you’ve missed is the paragraph containing the
quote text
you can improve the accessibility there using<blockquote>
to indicate to screen readers that the content inside that paragraph is a quote.✌️ I hope this helps you and happy coding!
Marked as helpful0 - @VCaramesPosted about 2 years ago
Hey there! 👋 Here are some suggestions to help improve your code:
- To center you content to your page, add the following to your Body Element:
body { min-height: 100vh; display: grid; place-content: center; }
-
The incorrect font is being used. You want to check the "style-guide" to download the correct one.
-
Along with the blank alt tag, you also want to include the aria-hidden=“true” to your stars to fully remove it from assistive technology.
-
The profile images Alt Tags need to be improved. It should state the following; “Headshot of -person’s full name-“
-
The Article Element is not best choice to wrap the testimonials since they cannot stand on their own. Instead, you want to wrapped each individual testimonial component in a Figure Element, the individuals information should be wrapped in a Figcaption Element and lastly, the testimonial itself should be wrapped in a Blockquote Element.
Code:
<figure> <figcaption></figcaption> <blockquote></blockquote> </figure>
More Info:
If you have any questions or need further clarification, let me know.
Happy Coding! 👻🎃
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord