Design comparison
Solution retrospective
Okay, I'm SURE there is an easier way of doing this one, but this is what I came up with. If you have any refactoring or other guru magic that I have yet to come across please enlighten me
Community feedback
- @VCaramesPosted about 2 years ago
Hey there! 👋 Here are some suggestions to help improve your code:
-
The
header
element is not needed for this challenge, since what is being built is a section of a site. So the entire thing should be wrapped in asection
element. -
Along with the blank alt tag, you also want to include the aria-hidden=“true” to your stars to fully remove it from assistive technology.
-
The profile images Alt Tags need to be improved. It should state the following; “Headshot of -person’s full name-“
-
Your CSS Reset is extremely bare and being underutilized. To fully maximize your CSS reset, you want to add more to it.
Here are few CSS Resets that you can look at and use to create your own or just copy and paste one that is already prebuilt.
https://www.joshwcomeau.com/css/custom-css-reset/
https://meyerweb.com/eric/tools/css/reset/
http://html5doctor.com/html-5-reset-stylesheet/
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding! 🍂🦃
Marked as helpful0@rox-stahlPosted about 2 years ago@vcarames
I had a total brain fart on those stars! Thanks for the suggestions on accessibility. I was looking for resets and how to utilize...time to spend researching this. I really appreciate the links! 🤗
0@VCaramesPosted about 2 years ago@rox-stahl
It happens to the best of us. lol
I am glad that I was able to help you out! Keep it up!
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord