@VCarames
Posted
Hey there! 👋 Here are some suggestions to help improve your code:
- The “star icons” serve no purpose other than to** be decorative;** They add no value. Their
alt tag
should left blank and have anaria-hidden=“true”
to hide them from assistive technology.
More Info:📚
https://www.w3schools.com/html/html_images_picture.asp
- The profile images
alt tags
need to be improved. It should state the following; “Headshot of -person’s full name-“
More Info:📚
- For the testimonials, it is best to to wrap each individual testimonial component in a
figure
element, the individuals information should be wrapped in afigcaption
element and lastly, the testimonial itself should be wrapped in ablockquote
element.
Code:
<figure>
<figcaption></figcaption>
<blockquote></blockquote>
</figure>
More Info:📚
- Your CSS Reset is extremely bare and being underutilized. To fully maximize your CSS reset, you want to add more to it.
Here are few CSS Resets that you can look at and use to create your own or just copy and paste one that is already prebuilt.
https://www.joshwcomeau.com/css/custom-css-reset/
https://meyerweb.com/eric/tools/css/reset/
http://html5doctor.com/html-5-reset-stylesheet/
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding!🎄🎁
Marked as helpful
@dhananjayandayalan
Posted
@vcarames It means a lot to me, thanks for a detailed feedback. I'll definitely look into it. WOW!!!!
@VCarames
Posted
@dhananjayandayalan
Glad I could help!☃️
Keep it up!
Marked as helpful
@dhananjayandayalan
Posted
@vcarames I really don't know how to reach, that's why this mentioned comment. Can you review my space tour website solution please? It would be very helpful for me to improvise it
https://www.frontendmentor.io/solutions/space-tourism-multipage-website-xI2Bh0U3E8
Please leave me your twitter if you've one🙂