Design comparison
Community feedback
- @malek-btPosted almost 2 years ago
Hey !, how are you ? I really liked the result of your project, but I have some tips that I think you will enjoy:
*Replace the <div > tag width <section > and <article> and remove the attribution class from <div> and make it in the <footer>for semantic page.You can read more about semantic html5_semantic_elements
*To use the star icon don't copy the full path Just use :
<img src="images/icon-star.svg" aria-hidden="true" class="star">
*You have used <br>. Using <br> is not only bad practice, it is problematic for people who navigate with the aid of screen reading technology. Screen readers may announce the presence of the element. This can be a confusing and frustrating experience for the person using the screen reader.
*I see your README file is MAL structured. README is a very important aspect of making projects, especially if you want other people to see it. You should read the README file and the README-template file to make nice one.
The rest is good, I hope those tips will help you! 👍
2
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord