@alejandrodiazpugh
Posted
I like the tweaks you made to the original design. My only issue would be the attribution section being always stuck to the bottom of the page, even while scrolling. I reccomend reading this, in case it wasn't a deliberate choice: https://www.freecodecamp.org/news/how-to-keep-your-footer-where-it-belongs-59c6aa05c59c/
As for the codebase, everything's fine, I wouldn't set the media queries inside every tag, but that's personal preference. Although, I don't get why you're using custom properties while using SASS.
Great looking page!
@rehberbey
Posted
@alejandrodiazpugh Hello, I'm glad you like my work. 💎
-
Actually, I pasted it down using position:fixed, you can check my code. Is this a subjective review or an accessibility issue? 🤨
-
As for the media query, I can say it's a matter of taste. 😏
-
Why am I using CSS custom properties instead of SCSS custom properties? CSS custom properties are dynamic. You can replace it with CSS or JS. Well, I'm using it wrong. There was no light/dark site construction in the Frontend Mentor projects I have done so far. I also added fine touches to my work, as you put it, to show my difference. I was trying not to go beyond the style-guide given in the project. If I needed a new color, I would assign it directly to the color property, for example, to make it faster.
