Design comparison
Solution retrospective
🫡 Hello, Frontend Mentor Army. This is my solution for the Social Proof Section
Another great Challenge by Front-End Mentor #LearningByDoing
I'll be happy to hear any useful feedback and advice! 🙌
Community feedback
- @Nadine-GreenPosted almost 2 years ago
HEY DEVESH!
I noticed that
.cardContainer
does not have amax-width
, to prevent the container from constantly expanding, you will have to implement this.I also noticed that the background was not added as well, just something to remind you of :)
IF THIS WAS HELPFUL IN ANY WAY, DON'T HESITATE TO MARK IT AS HELPFUL :)
HAPPY CODING!
1@MelvinAguilarPosted almost 2 years ago@Nadine-Green Hey there! 👋, I have a small comment for you. Try to avoid asking for the comment to be marked as "helpful", and don't write it in capital letters, as the Community guidelines and platform creator mention: "This places unnecessary pressure on the solution author to mark your comment as helpful, which is best avoided", which may result in a report and a message from them. :(
Since you are top mentors, we avoid establishing a trend of asking to be marked as "helpful" , Happy Coding!🎄
1 - @catherineisonlinePosted almost 2 years ago
Nice solution 🤩
To improve the code there are several tips how you can use alt attribute for images. If the image is just for decoration you can still write alt attribute but leave it empty, such images don’t need any alt tag but you will need to also add aria-hidden=“true”.
According to MDN “The alt attribute holds a text description of the image, which isn't mandatory but is incredibly useful for accessibility — screen readers read this description out to their users so they know what the image means. Alt text is also displayed on the page if the image can't be loaded for some reason: for example, network errors, content blocking, or linkrot.“
IF THIS WAS HELPFUL PLEASE MARK IT AS HELPFUL 🤩
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord