Design comparison
SolutionDesign
Solution retrospective
Hello,
Here my solution for this challenge. I noticed couple things I would like to improve such as the text under starting with "10k users...".
If somebody can look at it and give some feedback, I'd appreciate it :)
Community feedback
- @VCaramesPosted almost 2 years ago
Hey there! 👋 Here are some suggestions to help improve your code:
- Remove the
br
elements you added to the headings, it is unnecessary.
- The “star icons” serve no purpose other than to** be decorative;** They add no value. Their
alt tag
should left blank and have anaria-hidden=“true”
to hide them from assistive technology.
More Info:📚
https://www.w3schools.com/html/html_images_picture.asp
- The profile images
alt tags
need to be improved. It should state the following; “Headshot of -person’s full name-“
More Info:📚
- For the testimonials, it is best ✅ to to wrap each individual testimonial component in a
figure
element, the individuals information should be wrapped in afigcaption
element and lastly, the testimonial itself should be wrapped in ablockquote
element.
Code:
<figure> <blockquote></blockquote> <figcaption></figcaption> </figure>
More Info:📚
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding! 🎄🎁
Marked as helpful0@VCaramesPosted almost 2 years ago- Your
CSS Reset
is being underutilized. To fully maximize it, you will want to add more to it.
Here are some examples that you can freely use:
- For improved accessibility 📈 for your content, it is best practice to use
em
formedia-queries
. Using these unit gives users the ability to scale elements up and down, relative to a set value.
Marked as helpful0 - Remove the
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord