Frontend Mentor | social-proof coding challenge solution

@VCarames

Posted over 1 year ago

Hey there! 👋 Here are some suggestions to help improve your code:

The “star icons” serve no purpose other than to** be decorative;** They add no value. Their alt tag should left blank and have an aria-hidden=“true” to hide them from assistive technology.

More Info:📚

https://www.w3schools.com/html/html_images_picture.asp

The profile images alt tags need to be improved. It should state the following; “Headshot of -person’s full name-“

More Info:📚

Headshot Alt Text

For the testimonials, it is best ✅ to to wrap each individual testimonial component in a figure element, the individuals information should be wrapped in a figcaption element and lastly, the testimonial itself should be wrapped in a blockquote element.

Code:

<figure>
   <blockquote></blockquote>
   <figcaption></figcaption>
</figure>

More Info:📚

MDN Figure Element

If you have any questions or need further clarification, feel free to reach out to me.

Happy Coding! 🎄🎁

Marked as helpful

@VCarames

Posted over 1 year ago

Your CSS Reset is being underutilized. To fully maximize it, you will want to add more to it.

Here are some examples that you can freely use:

For improved accessibility 📈 for your content, it is best practice to use em for media-queries. Using these unit gives users the ability to scale elements up and down, relative to a set value.

Marked as helpful

social-proof