Design comparison
SolutionDesign
Community feedback
- @VCaramesPosted almost 2 years ago
Hey there! 👋 Here are some suggestions to help improve your code:
- To properly center your content to your page, you will want to add the following to your
body
element (this method uses CSSGrid
):
body { min-height: 100vh; display: grid; place-content: center; }
More Info:📚
[Centering in CSS][https://moderncss.dev/complete-guide-to-centering-in-css/]
- The
aside
element is not needed for this challenge and its being used incorrectly.
- The “star icons” serve no purpose other than to** be decorative;** They add no value. Their
Alt Tag
should left blank and have anaria-hidden=“true”
to hide them from assistive technology.
More Info:📚
https://www.w3schools.com/html/html_images_picture.asp
- The
article
element is not the best choice for wrapping these testimonials. In order to use thearticle
element the component needs to be able to make sense on its own and be independently distributable (can be used in on another site).
- You instead, want to wrap each individual testimonial component in a
Figure
element, the individuals information should be wrapped in aFigcaption
element and lastly, the testimonial itself should be wrapped in aBlockquote
element.
Code:
<figure> <figcaption></figcaption> <blockquote></blockquote> </figure>
More Info:
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding!🎄🎁
0 - To properly center your content to your page, you will want to add the following to your
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord