Vanza Setia• 27,795
@vanzasetia
Posted
Hi, Abdulquddus! 👋
Here are some suggestions for improvements:
- Don't use
id
selectors for styling. There are two reasons for not using ID’s to style content:- They mess up specificity because they are too high (the most important reason).
- They are unique identifiers. So, they are not reusable on the same page.
- Learn more — What the ID attribute is REALLY for
- Wrap
<p class="text">
that wraps the quote content with<blockquote>
. - Avoid using
px
unit for font sizes. Userem
orem
instead. Relative units such asrem
andem
can adapt when the users change the browser's font size setting. Learn more — Why you should never use px to set font-size in CSS - Don't overuse
<section>
tags. It is better to use<div>
instead for styling purposes. Also,<section>
without being labeled properly has no meaning which is the same as<div>
elements. Reference: WebAIM: HTML Semantics and Accessibility Cheat Sheet - Be aware of "divitis". Learn more about it — Optimizing Markup and Styles | Designing for Performance #divitis
I hope my suggestions help you. Have fun coding! 😄
Marked as helpful
0