social-proof-section-master | Responsive
Design comparison
Community feedback
- @malek-btPosted almost 2 years ago
Hey !, how are you ? I really liked the result of your project, but I have some tips that I think you will enjoy:
1.Remove the
<div class="container">
and make the class="container" in the <main> tag.2.Replace the <div > tag width <section > and <article>for semantic page . You can read more about semantic here: HTML Semantic Elements.
3.Remove the attribution class from <div> and make it in the <footer>
4.Instead of using pixels in font size, use relative units of measure like rem or em. The font size in absolute length units (px) does not allow users with limited vision to change the text size in some browsers.
5.I see your README file is MAL structured. README is a very important aspect of making projects, especially if you want other people to see it. You should read the README file and the README-template file to make nice one.
The rest is good, I hope those tips will help you! 👍
Good job!
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord