Design comparison
Solution retrospective
All comments are welcome
Community feedback
- @correlucasPosted about 2 years ago
👾Hello Nien, congratulations for your new solution!
🎨 You’ve done really good work here putting everything together, I’ve some suggestions to improve the design:
1.To add the two
wave
svg background images in the (top/bottom),, the best way is by usingbackground-image
to manage it since adding them to thebody
you make sure it will be under everything, to manage different images inside a single css property asbackground-image
you use the comma inside each properties declare the single modification for each circle separated. See the code below to see your solution with those backgrounds applied:body { background-image: url(images/bg-pattern-top-desktop.svg), url(images/bg-pattern-bottom-desktop.svg); background-position: left -185px top -236px, right 10px bottom -300px; background-repeat: no-repeat, no-repeat; background-attachment: fixed, fixed; background-size: contain, contain; }
2.Improve your code html markup and semantics. You can replace the
<div>
that wraps each card with<article>
you can wrap the paragraph with the quote with the tag<blockquote>
this way you'll wrap each block of element with the best tag in this situation. Pay attention that<div>
is only a block element without meaning.✌️ I hope this helps you and happy coding!
Marked as helpful1@trandainienPosted about 2 years ago@correlucas really appreciate all your feedback. I will keep them in mind. Thank you
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord