Design comparison
SolutionDesign
Solution retrospective
Hi there!
Here's my solution for this challenge. It is my pleasure to hear your feedback. Questions appreciated!
TODO: -mobile view
Cheers!
Community feedback
- @VCaramesPosted almost 2 years ago
Hey there! 👋 Here are some suggestions to help improve your code:
- The "We only provide great products combined with excellent customer service. See what our satisfied customers are saying about our services" is not a heading, it should instead be wrapped in a
paragraph
element.
- For the profile images
alt tag
description, it should never* include the following keywords; “image”, “photo”., “picture” and any variation of them.
- The
article
element is not the best choice for wrapping these testimonials. In order to use thearticle
element the component needs to be able to make sense on its own and be independently distributable (can be used in on another site).
- To better improve the semantics of your component, you want to wrap each individual testimonial component in a
Figure
element, the individuals information should be wrapped in aFigcaption
element and lastly, the testimonial itself should be wrapped in aBlockquote
element.
Code:
<figure> <figcaption></figcaption> <blockquote></blockquote> </figure>
More Info:
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding!🎄🎁
Marked as helpful0 - The "We only provide great products combined with excellent customer service. See what our satisfied customers are saying about our services" is not a heading, it should instead be wrapped in a
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord