Design comparison
Solution retrospective
I will appreciate any improvements.
Community feedback
- @correlucasPosted about 2 years ago
👾Hello Diaa Faris, Congratulations on completing this challenge!
Here’s some tips to improve your component design:
To add the two
wave
svg background images in the (top/bottom),, the best way is by usingbackground-image
to manage it since adding them to thebody
you make sure it will be under everything, to manage different images inside a single css property asbackground-image
you use the comma inside each properties declare the single modification for each wave svg image separated. See the code below to see your solution with those backgrounds applied:body { background-image: url(../images/bg-pattern-top-desktop.svg), url(../images/bg-pattern-bottom-desktop.svg); background-position: left -185px top -236px, right 10px bottom -300px; background-repeat: no-repeat; background-attachment: fixed; background-size: contain, contain; font-family: "League Spartan", sans-serif; display: flex; justify-content: center; align-items: center; overflow-x: hidden; }
✌️ I hope this helps you and happy coding!
Marked as helpful1@diaaFarisPosted about 2 years ago@correlucas Thank you for reminding me. I didn't notice that there is a background at all XD.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord