Design comparison
Solution retrospective
Any Suggestions or Recommendations? Thank you in advance.
Community feedback
- @dwhensonPosted over 3 years ago
Hi @OmarIsmail277 nice work on this one - the live page works well and you've obviously given it a lot of though!
Some suggestions:
-
You could take advantage of some of HTML's built in properties by using a <h1> for the heading and a regular <p> for the text in the
.count
element. This might help simplify some of your CSS. -
Similarly for the star images - you don't really need to have them all wrapped in span. If your images are inline elements they should work in a similar way without the wrapper. Again this might help simplify things for you (and again use a <p> for the text perhaps?)
-
In the bottom sections I also feel that the <p> element probably isn't the most appropriate here. Maybe a 'div' would be better and then use the
p
inside the div to wrap the text. (but nice use offloat
on the avatars - I wouldn't have thought of that!)
Great stuff and keep up the good work.
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord