Design comparison
Solution retrospective
This project it's look easy ,but i was took me a lot of time because i did it at irregular intervals. bless to Allah i finished it now but without @media quarry . if you could help me and give me advices that will be great. thanks for everyone /
Community feedback
- @correlucasPosted about 2 years ago
👾Hello @Yoseif-Alfiky-1, Congratulations on completing this challenge!
Great code and great solution! I’ve few suggestions for you that you can consider adding to your code:
1.Add the website favicon inserting the svg image inside the
<head>.<link rel="icon" type="image/x-icon" href="./images/favicon-32x32.png">2.The html markup for this solution its built entirely with
<div>and you can improve it using semantics tags to describe what its inside each block of content. You can replace the<div>that wraps each card with<article>you can wrap the paragraph with the quote with the tag<blockquote>this way you'll wrap each block of element with the best tag in this situation. Pay attention that<div>is only a block element without meaning.✌️ I hope this helps you and happy coding!
0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord