Design comparison
Solution retrospective
Hi,
Guys, how can I write Decorative Images
img tag properly? Any feedback will be accepted with appreciation. 👍
Thanks.
Community feedback
- @ApplePieGiraffePosted almost 2 years ago
Hey, Mirza Monirul Alam! 👋
Nice work on this challenge! 👍 Your solution looks good and is responsive! 👏
You don't need to add
role="presentation"
to the star icon images since theimg
tag is already semantic and you've left thealt
attribute empty for those images (good choice, btw) meaning screen readers will ignore those elements.Another small tip I have for you is to add
min-height: 100vh
to thebody
element so that it will always be at least as high as the user's screen and there won't be any empty space to the bottom of the design.Besides that, you should add a favicon to the site. There should be one in the starter files for this challenge that you can use. 😉
Hope you find this helpful. 😊
Keep coding (and happy coding, too)! 😁
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord