social-proof-section using flexbox and grid properties
Design comparison
Solution retrospective
i look up to ur negative and positive posts on my code feel free to post :) and thanks .
Community feedback
- @catherineisonlinePosted almost 2 years ago
Nice solution 🤩
To improve the code there are several tips on how you can use an alt attribute for images. If the image is just for decoration you can still write an alt attribute but leave it empty, such images don’t need any alt tag but you will need to also add aria-hidden=“true”. Otherwise, you need to use an alt tag to describe the image for accessibility.
According to MDN “The alt attribute holds a text description of the image, which isn't mandatory but is incredibly useful for accessibility — screen readers read this description out to their users so they know what the image means. Alt text is also displayed on the page if the image can't be loaded for some reason: for example, network errors, content blocking, or linkrot.“
IF THIS WAS HELPFUL PLEASE MARK IT AS HELPFUL 🤩
Marked as helpful0 - @VCaramesPosted almost 2 years ago
Hey there! 👋 Here are some suggestions to help improve your code:
- Since this a section of a full site, the
main
element should be wrapping the entire section and theheader
element is not needed.
- Along with the blank
Alt Tag
, you also want to include thearia-hidden=“true”
to your “stars” to fully remove them from assistive technology.
More Info:📚
https://www.w3schools.com/html/html_images_picture.asp
- The profile images are not decorative. They need to haveAlt Tags; It should state the following; “Headshot of -person’s full name-“
- To improve the semantics of your component, you want to wrap each individual testimonial component in a
Figure
element, the individuals information should be wrapped in aFigcaption
element and lastly, the testimonial itself should be wrapped in aBlockquote
element.
Code:
<figure> <figcaption></figcaption> <blockquote></blockquote> </figure>
More Info:
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding!🎄🎁
0 - Since this a section of a full site, the
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord