Skip to content
Submitted almost 4 years ago

Social proof - Second attempt

Daveā€¢5,295
@dwhenson
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Social proof section
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

I wanted to retry this challenge as it was the first one I attempted since really going back to basics. I think I did OK, I did it in less than half the time of my last attempt, and I think the code is DRYer and more organised. I chose this one as I want to watch how Kevin Powell does it on YouTube now...

Any comments or suggestions are most welcome.

Community feedback

  • ApplePieGiraffeā€¢30,545
    @ApplePieGiraffePosted almost 4 years ago

    Great job, Dave! šŸ‘

    Your solution looks good and responds very nicely! šŸ™Œ

    Haha, I definitely feel like I want to redo a few challenges, too! šŸ˜‰ It's nice to go back and do things differently and learn a thing or two (and hopefully do things better). šŸ˜…

    If I'm not mistaken, the only thing I might suggest is not adding any alt text to the SVG stars since the rating itself is specified by the text and so that screen readers don't read out the SVG stars 5 times for each review box. Or you could just use CSS background images to add the stars instead and thereby remove them from your markup.

    Keep coding (and happy coding, too)! šŸ˜

    1
    Daveā€¢5,295
    @dwhensonPosted almost 4 years ago

    Thanks as always @ApplePieGiraffe - yes I was actually wondering the same thing. Thanks for clearing that up. Appreciate your comments as always!

    0
  • Aleksandr Aksenovā€¢750
    @axevldkPosted almost 4 years ago

    Hi, @dave ! I have studied your work, and it's really great ~ šŸ‘ Clean in code and perfect in using grid.

    I have learnt a lot from your code. Happy coding ~ āœØ

    1
    Daveā€¢5,295
    @dwhensonPosted almost 4 years ago

    Thanks for the nice words @axevldk!

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord