Design comparison
Solution retrospective
The solution is quite short of what the design requires,I'm yet to be totally comfortable with CSS grid and that's the part of my code that i am unsure of.
All feedback is welcome
Community feedback
- @dan-ayalahdezPosted over 2 years ago
Hello,
Well done, Ombasa, the design look pretty similar to the original, altough i would like to give you some suggestions about your html code.
It seems like all your components are floating around the page by themselves, one thing that you can do in order to maintain these aligned and centered is wrapping them in a container, in this case i suggest you to wrap the entire code inside the body in a
<main>
tag, and make the body element either agrid
and useplace-content: center;
orflexbox
and usealign-items: center
andjustify-content:center;
to keep them contained in the center.Later you can implement more wrapping, for example you can utilize the
<section>
tag to separate the top section(The title/description and the star containers), and the bottom section (the buyers containers),and easly apply padding or margin to separate these two.Since i am learning too, i will let more experienced devs to complement with more feedback, Good Luck! :)
Marked as helpful1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord