Design comparison
Solution retrospective
Hi there!.
here's my solution for this activity!. It was a little more difficult than expected, but it helped me to practice positioning and structuring the content of a web page.
each feedback is appreciated!!.
Hey buenas!.
Aquí esta mi solución para esta actividad!. Fue mas difícil de lo que esperaba, pero me ayudo mucho a practicar el posicionamiento y estructurado del contenido de una pagina web.
todo tipo de feedback se agracede!.
Community feedback
- @VCaramesPosted about 2 years ago
Hey there! 👋 Here are some suggestions to help improve your code:
- To properly center your content to your page, you will want to add the following to your Body Element (this method uses CSS Grid):
body { min-height: 100vh; display: grid; place-content: center; }
-
The profile images Alt Tags need to be improved. It should state the following; “Headshot of -person’s full name-“
-
To improve the semantics of your component, you want to wrap each individual testimonial component in a Figure Element, the individuals information should be wrapped in a Figcaption Element and lastly, the testimonial itself should be wrapped in a Blockquote Element.
Code:
<figure> <figcaption></figcaption> <blockquote></blockquote> </figure>
More Info:
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding! 🍂🦃
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord