Social proof page - css grid & flexbox - responsive mode activated 🙃

Community feedback

• 

  Lucas 👾•104,340

  @correlucasPosted about 2 years ago

  👾Hello @Aatypic, Congratulations on completing this challenge!

  Great code and great solution! I’ve few suggestions for you that you can consider adding to your code:

  1.You did a really good work here putting everything together, something you can improve its your code html markup and semantics. You can replace the <div> that wraps each card with <article> you can wrap the paragraph with the quote with the tag <blockquote> this way you'll wrap each block of element with the best tag in this situation. Pay attention that <div> is only a block element without meaning.

  2.Its really nice that you’ve used some animation and effects! Something to improve the accessibility its to add a media query reducing the motion.The prefers-reduced-motion CSS media feature is used to detect if the user has requested that the system minimize the amount of non-essential motion it uses. Here’s the code for that:

  /* Remove all animations, transitions and smooth scroll for people that prefer not to see them */
  @media (prefers-reduced-motion: reduce) {
    html:focus-within {
      scroll-behavior: auto;
    }
  
    *,
    *::before,
    *::after {
      animation-duration: 0.01ms !important;
      animation-iteration-count: 1 !important;
      transition-duration: 0.01ms !important;
      scroll-behavior: auto !important;
    }
  }
  

  ✌️ I hope this helps you and happy coding!

  1

  ---

  

  Aatypic•490

  @AatypicPosted about 2 years ago

  @correlucas Hi thanks for your feedback

  -I will look into the semantic.

  -The css resets with the prefers-reduced-motion is already in my code 😅

  1

  

  Lucas 👾•104,340

  @correlucasPosted about 2 years ago

  @Aatypic Oh! I didnt saw that, maybe I was with another repository opened and I made some confusion. So you're fine, by the way, nice animations you've add. =)

  0

  

  Aatypic•490

  @AatypicPosted about 2 years ago

  @correlucas haha no worries. Thank you :D

  0