Design comparison
Solution retrospective
Hey ! Q&D integration, if i may done something better, feel free to give your feedback !
Community feedback
- @emestabilloPosted about 4 years ago
Hi Benjamin, good job completing this challenge! Here are some thoughts:
-
The background for desktop is also being used for mobile widths
-
I would look into multiple backgrounds so you don't have to manage the background images with pseudoelements and z-index
-
At the 900px breakpoint, the component is almost touching the gutter. It is also not occupying the entire viewport height.
-
.review
is missingdisplay: flex
for desktop -
Lastly, you should address the issues in the report with missing
alt
text, since it is an html standard and the images will be inaccessible.
Hope this helps :-)
0@bsabarduPosted about 4 years agoHi, thanks a lot for your feedback, i'll gonna have a look and do some updates.
Benjamin
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord