Social Proof Challenge using Flexbox with desktop and mobile design!

Community feedback

• 

  Connor Z•5,115

  @zuolizhuPosted about 4 years ago

  Hey Stanley,

  Nice try on this challenge! Both desktop and mobile views look good 👍!

  The stars are stretched in height when the screen size is below 1440px 🧐.

  One way you can fixed this is to remove the height: 30%; for the .ratingStars img {}. There is no need to change the height or width of the star. At the same time, change the width of . ratingStars to 117px (This is the actual width from the sketch file).

  .ratingStars {
      align-items: center;
      display: flex;
      justify-content: space-between;
      margin-left: 32px;
      margin-right: 32px;
      width: 117px;
      min-width: 117px;
  }
  .ratingStars img {
      /* height: 30%; */
  }
  

  I think this can give you a good result of the stars.

  By the way, you can open the .svg file in your text editor, and copy the code into the HTML file, something like this:

  // Instead of using <img> tag
  🙅‍♂️<img src="./images/icon-star.svg" alt="star rating">🙅‍♂️
  // Using svg code directly
  🙆‍♂️<svg xmlns="http://www.w3.org/2000/svg" width="17" height="16"><path ... /></svg>🙆‍♂️
  

  The reason I prefer this way, is because each <img> tag will make a request to fetch the image file. And svg can be rendered directly in the browser from the HTML code, so that you can reduce the number of requests by adding it directly in your code. Which can speed up your page loading a little bit 😉.

  There is nothing wrong to use margins to make the staggered patterns. Your code from lines 87-100 and lines 133-148 are good.

  However, the elements above 375px are squeezed together. And I found 👀 you have @media screen and (max-width: 375px) to the <section class="upper">.

  That means the the code with in @media screen and (max-width: 375px) will be only applied if the screen size is below or equal to 375px.

  And I think change it to @media screen and (max-width: 1024px) will fix the squeezed problem.

  Hope my nerdy comment helps🤓.

  Happy coding🙌!

  4

  ---

  

  Stanley Chen•10

  @DannyShienPosted about 4 years ago

  Thank you @zuolizhu for the feedback! I greatly appreciate you taking the time to offer your suggestions! I will consider your feedbacks and re-evaluate my code.

  Also, I apologize for a late response. I have been caught up with a mini side project I've been working on late last year and completely forgot to check back here for any community responses.

  Thanks again! ✌🏼

  0