Melvin Aguilar ๐ง๐ปโ๐ปโข 61,220
@MelvinAguilar
Posted
Hello there ๐. Good job on completing the challenge !
I have some suggestions about your code that might interest you.
- You should change your
<section>
element to a landmark<main>
.
- Images should always have an
alt
attribute; otherwise, the filename will be read by screen readers. For icons, you can leave thealt
attribute empty, but never omit it.
- The person's photo should have an
alt
attribute with their name.
<span>
is an inline element used for styling but is not a semantic tag. You should use paragraphs or headings to better describe your page's content.
- I feel that the
display: inline-block;
andoverflow: hidden;
properties should not be on thebody
element. It's a common practice to limit the width of your current<section>
withmax-width: 1200px;
.
I hope you find it useful! ๐ Above all, the solution you submitted is great!
Happy coding!
Marked as helpful
0
SheikBazithโข 240
@SheikBazith
Posted
@MelvinAguilar these are some of the best advices I got. I am preparing myself to code better and these will help me alot. Thanks
0