Design comparison
Community feedback
- @correlucasPosted about 2 years ago
👾Hello @sriramyrskprofessional, Congratulations on completing this challenge!
Great code and great solution! I’ve few suggestions for you that you can consider adding to your code:
Your html is working but you can improve it using meaningful tags and replace the divs, for example the main div that takes all the content can be wrapped with
<main>
or section, about the cards you can replace the<div>
that wraps each card with<article>
you can wrap the paragraph with the quote with the tag<blockquote>
this way you'll wrap each block of element with the best tag in this situation. Note that<div>
is only a block element without meaning, prefer to use it for small blocks of content.This article from Freecodecamp explains the main HTML semantic TAGS: https://www.freecodecamp.org/news/semantic-html5-elements/
✌️ I hope this helps you and happy coding!
0 - @Faris-ThibaniPosted about 2 years ago
Congratulations!
I really like how you did this project!
Aside from accessibility issues that would punch the SEO, you implemented the instructions very well. Perhaps try to use the semantic TAGS. This link from freecodecamp might be useful: https://www.freecodecamp.org/news/semantic-html5-elements/
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord