@correlucas
Posted
👾Hi Neil Kanakia, congrats on completing this challenge!
I've just opened your live site and I can say that you did a great job putting everything together! There's some tips to improve your solution:
1.You did a really good work here putting everything together, something you can improve its your code html markup and semantics. You can replace the <div>
that wraps each card with <article>
you can wrap the paragraph with the quote with the tag <blockquote>
this way you'll wrap each block of element with the best tag in this situation. Pay attention that <div>
is only a block element without meaning.
2.It is not advisable to use IDs as CSS selectors because if another element in the page uses the same/similar style, you would have to write the same CSS again. Even if you don't have more than one element with that style right now, it might come later.
✌️ I hope this helps you and happy coding!