Design comparison
Solution retrospective
Hello good people,
I tried using SASS for the first time on this project (albeit sparingly). I have the nagging feeling my code isn't particularly clean - so any feedback on cleaning it up or simplifying it would be greatly appreciated! I'm not sure why the viewport height is so small in the preview above, which doesn't happen in the browser. Any ideas?
Community feedback
- @grace-snowPosted almost 4 years ago
Hi, I think this looks good and you should be pleased with it. You could probably get a little closer to the design on desktop still, but it's pretty close.
Looking at the code, I wonder what happens if you zoom out to a really huge screen? As you've only set a width on the container in percentages and no max-width I'd expect the layout might break a bit. You might want to make the h1 a little larger and give that whole block a max width too.
With scss, you are technically using it but you're not leveraging any of its power yet. I'm sure that will come in time though, so don't worry about it.
One learning point is when you write alt text you never need to say words like 'picture of' or 'image' as that is an image element, so is announced as an image already.
I hope this is helpful. Good luck with your code learning ☺
2@jordy-whitePosted almost 4 years ago@grace-snow Hi Grace. Thank you so much for the constructive feedback! I will play around with the max-widths, which I hadn't really learned to appreciate until now. Have a great weekend!
0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord