
Design comparison
SolutionDesign
Community feedback
- @cosminbordianuPosted 2 months ago
Congratulations on finishing this project! First of all, I’m also a beginner, so I’ll try my best to offer some advice, but please take it as such.
HTML:
- You can replace the <div> elements with the class "link" by using <a> tags instead. This will semantically improve the structure since links are meant to be represented by anchor tags.
CSS:
- Use relative units like "rem"/"em" instead of px for margins, padding, and font-size because it’s better for accessibility. This ensures that the layout scales more easily for users who adjust their font size for readability.
- Consider using a modern CSS reset at the start of the styles in every project. Like this one Modern CSS Reset. This will help reset a list of default browser styles.
- In the actual design the background color of the links change when you hover over them.
Overall, it is a solid project. Keep up the good work!
Marked as helpful1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord