Social Profile Main

Community feedback

• 

  AliAsghar Zare•70

  @iliAsgharPosted 8 months ago

  great job! 💪 you did well in layout and Positioning the elements. some things that I think needs a bit of a tweak:

  1. i noticed you used <section> for designing the buttons . it's usually recommended to use <a></a> for buttons (other than form buttons . those should be <button> , because it can submit a form entry) . it's because the <button> tag or any other tag can't link to another website . according to MDN - <Section>, <section> is a generic sectioning element, and should only be used if there isn't a more specific element to represent it.
  2. as it was intended ( i think it was, maybe i'm mistaken 😶) , it's better to have a :focus state for the buttons . simply an outline around them to help the keyboard users.
  3. even if a project is small and can be done without them , Defining a class for each element will get you used to naming and nesting the elements better . one simple naming convention is the BEM naming . you can check it out HERE.

  i hope you have fun continuing your Web Development journey , Keep up the good work! ✅🤗🙂

  0

  ---

  

  AliAsghar Zare•70

  @iliAsgharPosted 8 months ago

  @iliAsghar i just noticed you have a bunch of solutions in your profile ! im more in a learning journey myself, and since the solution was recommended for me , i thought i'd share some of my exp here . 😶🙌

  0

  

  Skalex Stuch•210

  @mussinoPosted 8 months ago

  Is OK! thanks for your feedback, as I said is always welcome and you were right I should use all those suggestion you told me. Buttons are welcome! @iliAsghar

  1