Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Social Profile Links

@sanjaymuz25

Desktop design screenshot for the Social links profile coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

Boris 2,870

@mkboris

Posted

Nice work sanjaymuz25, here are some suggestions for improvements

  • All content should be wrapped within landmarks. Wrap a main tag around the .container and a footer for the attribution.
  • Use a separate file for your css
  • To improve the semantic meaning of these social media links, you should use the a (anchor) tag instead of the div. It's not good practice to wrap every element in div because divs aren't semantic. Also, using an unordered list ul to group the social media links is a better approach for both semantics and accessibility.
  • Every page should have at least one heading typically an h1 element to provide a clear structure. The name should be a heading. The other texts should be p paragraph elements.
  • Font-size should be written in rem not px
0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord