Design comparison
SolutionDesign
Community feedback
- @mkborisPosted 3 months ago
Nice work sanjaymuz25, here are some suggestions for improvements
- All content should be wrapped within landmarks. Wrap a
main
tag around the .container and afooter
for the attribution. - Use a separate file for your css
- To improve the semantic meaning of these social media links, you should use the
a
(anchor) tag instead of thediv
. It's not good practice to wrap every element indiv
because divs aren't semantic. Also, using an unordered listul
to group the social media links is a better approach for both semantics and accessibility. - Every page should have at least one heading typically an
h1
element to provide a clear structure. The name should be a heading. The other texts should bep
paragraph elements. - Font-size should be written in
rem
not px
0 - All content should be wrapped within landmarks. Wrap a
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord