@kaamiik
Posted
Hi. Congrats for doing this challenge. I have some notes I wanna mention:
-
You should not limit your width and height in a container that have text inside. Usually you do not need width and height for your code. You only need
min-height: 100vh
for justifying your card insidebody
andmax-width
for some elements. If you usemax-width
here, then you do not need any media query for the card. -
Add a better
alt
for your profile picture. -
You can not wrap two interactive elements inside each other(I mean
a
andbutton
) you can use either one of them. If the interactive element take you to a new page, then It'sa
and if It's do an action, then It's abutton
. -
The
footer
should be outside themain
.
I'll add to the above that you need to change the headings in this. The person's name should be a h1 as its the main heading for all content on the page.
And the location should not be a heading at all. It is not appropriate heading content for the subsequent content..
It's important to only use headings where appropriate, and then place in hierarchical order to reflect the structure of the content.
I also recommend placing the list of links inside a list element with list items. (Once you've removed the buttons)
Marked as helpful