Social profile card NEWBIE - with HTML & Pure CSS / SEO / Responsive

Community feedback

• 

  P

  Kamran Kiani•1,280

  @kaamiikPosted about 1 month ago

  Hi. Congrats for doing this challenge. I have some notes I wanna mention:

  1. You should not limit your width and height in a container that have text inside. Usually you do not need width and height for your code. You only need min-height: 100vh for justifying your card inside body and max-width for some elements. If you use max-width here, then you do not need any media query for the card.

  2. Add a better alt for your profile picture.

  3. You can not wrap two interactive elements inside each other(I mean a and button) you can use either one of them. If the interactive element take you to a new page, then It's a and if It's do an action, then It's a button.

  4. The footer should be outside the main.

  0

  ---

  

  T

  Grace•31,270

  @grace-snowPosted about 1 month ago

  I'll add to the above that you need to change the headings in this. The person's name should be a h1 as its the main heading for all content on the page.

  And the location should not be a heading at all. It is not appropriate heading content for the subsequent content..

  It's important to only use headings where appropriate, and then place in hierarchical order to reflect the structure of the content.

  I also recommend placing the list of links inside a list element with list items. (Once you've removed the buttons)

  2

  

  P

  Facundo Andrés De Los Rios•200

  @FacundoDLRPosted about 1 month ago

  @kaamiik Great, thanks for the suggestions. Today I made all those changes and the truth is that the result looks much better. Improve the fixed measurements (width and height) by maximums and minimums.

  • Improve image alt.
  • Remove the button tag and improve the HTML by using a nav tag and an unordered list.
  • Finally, I removed the footer from the main page.

  0