Social medial links handler with html and css

Community feedback

• 

  P

  cookie-monster01•220

  @cookie-monster01Posted 4 months ago

  Hi, I would like to share some knowledge based on whatever I have learnt:

  1. .content - use min-height instead of height. min-height basically tells you the minimum height of an element/container, allowing it grow if required. height is restrictive/fixed to the given height, I understand that you have given it a 100vh and I wonder if it makes a difference in this case? if you or someone else can explain this?

  2. I noticed that you are giving color: var(--white) on multiple elements, if you apply it on the parent element, children will inherit the color, and same goes for the font-size. This way you can avoid repeating the code.

  Please correct me if I'm wrong.

  Marked as helpful

  0

  ---

  

  P

  Rinta Roy•100

  @rinta-gitPosted 4 months ago

  @cookie-monster01 Thank you for your suggestions! I used height instead of min-height because the content is static and will not exceed the viewport height. Therefore, changing to min-height wouldn't impact the layout in this case, but I appreciate your recommendation, and I agree that using min-height is a standard best practice.

  Regarding moving styles to the parent element, these styles cannot be directly applied to the parent because not all child elements share the same styling. However, I've ensured that the common styles are reused effectively across the individual child elements.

  I've considered both of your suggestions and made the necessary updates to my code. Thanks again for your valuable feedback!

  1