Skip to content
Submitted almost 4 years ago

Social Media w/ Darkmode theme switcher

Marcos•90
@NeradoOne
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Social media dashboard with theme switcher
  • HTML
  • CSS
  • JS
2junior

Design comparison

SolutionDesign

Solution retrospective

Que tal chicos aca mi solucion a este reto Frontendmentor, les agradecería criticas sobre la estructura y funcionalidad de mi código. Espero sus comentarios y muchas gracias.

Hi guys, thre is my solution for this Frontendmentor challenge, and i want to know what do you tihink about my code, structural and funcional. Thanks for all the coments and views!

Community feedback

  • Arturo Simon•1,785
    @artimysPosted almost 4 years ago

    Amazing job Marco. Your solution is responds nicely. Great use of prefers-color-scheme in your JavaScript. Your code looks great. Great method of using CSS custom properties to change theme colors.

    Aside from the missing headers in your article tags from the solution report. You have a good base to your semantics. I highly suggest if not already looking into a naming methodology to your css like BEM. more info here.

    Feedback:

    • apply a hover state to your custom toggle
    • in your JS, you might not need your if statement since either condition is the same line of code

    Keep on coding! 👍👍

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord