Social Media Links Page using CSS and HTML

Community feedback

• 

  Boris•2,870

  @mkborisPosted 6 months ago

  Hi Eric, great job on completing the challenge!

  Here are some suggestions that might be of interest to you.

  • All content should be wrapped within landmarks. Wrap a main tag around your whole content.
  • The buttons are supposed to be anchor a tags a styled liked buttons. Buttons are for events like toggling content or submitting a form and anchors are for navigation. In this case clicking on the link will navigate you to a new page, so you should should use the anchor element and style it like a button.
  • It's best practice linking Google fonts directly in the HTML head section rather than directly in your CSS file as it enables asynchronous downloading, improving page load times.

  Hope this helps.

  Marked as helpful

  0
• 

  azereje•100

  @AngelCoronaITPosted 6 months ago

  Does the solution include semantic HTML?

  Consider incorporating semantic HTML elements to enhance the structure and meaning of your code. Adding elements like <main></main> can be a good starting point.

  Does the layout look good on a range of screen sizes?

  I recommend starting the future projects in mobile first approach. If you go to inspection mode in your web browser you can see different screen sizes.

  Is the code well-structured, readable, and reusable?

  I think you could benefit from installing the Visual Studio Code extension 'Prettier'. It will help you not worry much about structuring your code.

  Does the solution differ considerably from the design?

  You should feel pretty good about this one, some feedback i would give you:

  • I believe you imported the font but didn't use it. You can add it to the body with font-family: "Inter", sans-serif;
  • You did a good job with the buttons, but I believe if they all have the same attributes in CSS, you can just make them one class shared between all of the buttons.

  Great Job on your progress!.

  Marked as helpful

  0