Design comparison
Solution retrospective
any suggestions ??
Community feedback
- @danielmrz-devPosted 9 months ago
Hello @unshreif!
Your solution looks great!
I have a suggestion for improvement:
- Use
<main>
to wrap the main content instead of<div>
.
š Tags like
<div>
and<span>
are typical examples of non-semantic HTML elements. They serve only as content holders but give no indication as to what type of content they contain or what role that content plays on the page.This tag change does not impact your project visually and makes your HTML code more semantic, improving SEO optimization as well as the accessibility of your project.
I hope it helps!
Other than that, great job!
Marked as helpful1 - Use
- @kyusufmPosted 9 months ago
Hi unshreif
Congratulations on finishing the challenges! Here are some suggestions to enhance your project further:
-
HTML Best Practices: Semantic HTML: Ensure that your HTML is semantic. For instance, use <main> for the main content and <section> for distinct sections.
-
Responsiveness Dont forget to add media-query so that the design won't break if we view it on phone (375px width)
you can learn more about the semantic tag in Semrush HTML5
1 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord