Social Media Links Challenge

Community feedback

• 

  P

  Boris•3,990

  @makogeborisPosted 3 months ago

  Great work, here are some suggestions

  • To improve the semantic meaning of these links, you should use the a (anchor) tag instead of the button tag. The a tag is used for navigation to other pages, while the button tag is designed for interactive actions like submitting forms or for events like toggling content. Also, using an unordered list ul to group the links is a better approach for both semantics and accessibility.
  • Every HTML page should have at least one heading element. The .name could be an h2
  • All content should be wrapped within landmarks. Wrap a main tag around the .container
  • It's best practice linking Google fonts directly in the HTML head section rather than directly in your CSS file as it enables asynchronous downloading, improving page load times.
  • Consider using a modern CSS reset at the start of the styles in every project. Like this one Modern CSS Reset. This will help reset a list of default browser styles.
  • Change the height: 100vh; on the body to min-height: 100vh;. Using min-height ensures the content can grow beyond the viewport height if necessary, while height would restrict it to exactly the viewport height, potentially causing overflow issues.
  • Font-size should be written in rem not px. This article explains it better Why font-size must NEVER be in pixels.

  Hope this helps, Good luck!

  Marked as helpful

  0
• 

  TanoyPaul•50

  @TanoyPaulPosted 3 months ago

  Perfect !

  0