Skip to content
Submitted about 2 months ago

Social Media link

Deng-Abuoi•40
@Deng-Abuoi
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Social links profile
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Community feedback

  • Steven Stroud•11,910
    @StroudyPosted about 2 months ago

    Exceptional work! You’re showing great skill here. I’ve got a couple of minor suggestions that could make this stand out even more…

    • Using a <main> tag inside the <body> of your HTML is a best practice because it clearly identifies the main content of your page. This helps with accessibility and improves how search engines understand your content.

    • I would put these into a <ul> <li>, and the text should be wrapped with a <a> so it is accessible with a keyboard using the tab key, Using an <a> tag for navigation is semantically correct, improves accessibility for screen readers, and ensures consistent behavior across browsers, unlike a <button> or a <div> not intended for links.

            <div class="buttons">
            <a href="#" class="btn">GitHub</a>
            <a href="#" class="btn">Frontend Mentor</a>
            <a href="#" class="btn">LinkedIn</a>
            <a href="#" class="btn">Twitter</a>
            <a href="#" class="btn">Instagram</a>
        </div>

    • Using a full modern CSS reset is beneficial because it removes default browser styling, creating a consistent starting point for your design across all browsers. It helps avoid unexpected layout issues and makes your styles more predictable, ensuring a uniform appearance on different devices and platforms, check out this site for a Full modern reset

    • For future project, You could download and host your own fonts using @font-face improves website performance by reducing external requests, provides more control over font usage, ensures consistency across browsers, enhances offline availability, and avoids potential issues if third-party font services become unavailable. Place to get .woff2 fonts

    • While px is useful for precise, fixed sizing, such as border-width, border-radius, inline-padding, and <img> sizes, it has limitations. Pixels don't scale well with user settings or adapt to different devices, which can negatively impact accessibility and responsiveness. For example, using px for font sizes can make text harder to read on some screens, Check this article why font-size must NEVER be in pixels. In contrast, relative units like rem and adjust based on the user’s preferences and device settings, making your design more flexible and accessible. Use px where exact sizing is needed, but prefer relative units for scalable layouts. If you want a deeper explanation watch this video by Kevin Powell CSS em and rem explained. Another great resource I found useful is this px to rem converter based on the default font-size of 16 pixel.

    • I think you can benefit from using a naming convention like BEM (Block, Element, Modifier) is beneficial because it makes your CSS more organized, readable, and easier to maintain. BEM helps you clearly understand the purpose of each class, avoid naming conflicts, and create reusable components, leading to a more scalable codebase. For more details BEM,

    I hope you’re finding this guidance useful! Keep refining your skills and tackling new challenges with confidence. You’re making great progress—stay motivated and keep coding with enthusiasm! 💻

    Marked as helpful
    0
  • Deng-Abuoi•40
    @Deng-AbuoiPosted about 2 months ago

    Hey Steven,

    I just wanted to say a huge thank you for your feedback on my profile card project! Your suggestions really helped me see things from a different perspective.

    I’ve made some changes based on your advice:

    I added a <main> tag for better accessibility and structure. I switched the buttons to an unordered list, which makes everything more organized. I included a modern CSS reset to keep the styling consistent across different browsers. I also changed font sizes to rem for better responsiveness. Lastly, I started using the BEM naming convention to keep my CSS tidy. I really appreciate your tips about hosting fonts locally and using a CSS reset; I’ll definitely keep those in mind for my future projects.

    Thanks again for your support! I'm looking forward to refining my skills even more.

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord