Social Media Dashboard with Theme Switcher

Community feedback

• 

  T

  Grace•31,270

  @grace-snowPosted almost 3 years ago

  I'm afraid the content on this is completely inaccessible at the moment. Try reading it with no images or styling(or try with a screenreader) and see how it becomes incomprehensible. That's what search engines and screenreader or other assistive tech users would get.

  It's actually the hardest part of this challenge, getting the semantics right. It definitely needs hidden headings and aria-labelledby and -describedby attributes

  And header__subtitle should n I t be a h2. That's data, numbers that would change so would never be a heading.

  I'd also use aria labeled by on the theme toggle - you have dark theme written right there in the html, let that be the label of the toggle

  Good luck

  Marked as helpful

  0

  ---

  

  Marcus Hugo•365

  @marcus-hugoPosted almost 3 years ago

  @grace-snow Thanks! I see what you mean about the h2 showing data. I'll go fix that now! I think i fixed all the accessibility and html issues. I added an aria-label to the input checkbox.

  0
• 

  T

  Grace•31,270

  @grace-snowPosted almost 3 years ago

  Content is spilling off screen for me. Remember to use max width not width on elements to allow them to grow up to a point and shrink as needed

  I'll pop some Screenshots in slack for you

  Marked as helpful

  0
• 

  Anosha Ahmed•9,300

  @anoshaahmedPosted almost 3 years ago

  To get rid of the accessibility/HTML issues shown in your Report, <section> and <article> usually need a heading; so if you don't need a heading in it, use some other element such as <div>

  Great job! :)

  Marked as helpful

  0

  ---

  

  Marcus Hugo•365

  @marcus-hugoPosted almost 3 years ago

  @anoshaahmed Thanks! I went through and added headings!

  1