Social media dashboard with HTML, SCSS, JS

Community feedback

• 

  Eric Karugu•210

  @erickaruguPosted over 3 years ago

  Also, I think synchronizing the body background-color theme switch with that of the cards will be a great add-on.

  0

  ---

  

  Clement•110

  @kamari-1Posted over 3 years ago

  @erickarugu32 I tried that with backround.transition and backround.transition *, also with ::before and ::after but it doesn't work.

  0
• 

  Eric Karugu•210

  @erickaruguPosted over 3 years ago

  Hello Clement👋,

  Your implementation looks superb. I love the layout and how you adopted the BEM CSS class naming convention👍

  The site looks great. The styling is working perfectly on my end too. A minor suggestion would be maybe to fix the few HTML issues as highlighted in the report.

  Regarding styling the top-border, I would suggest you go with the simpler and direct border-top styling, i.e for example border-top: 4px solid blue; in the various cards instead of using the ::before selector. I think this makes the border styling more similar to the one in the design. For the HSL not working, you can try converting the colors to RGB or hex to work in the linear-gradient.

  Otherwise, job well done!🙌 Happy Coding!😊

  0

  ---

  

  Clement•110

  @kamari-1Posted over 3 years ago

  @erickarugu32 Thanks. I just did fix the errors and my toggle broke . I don't know why it doesn't show the background anymore. Pls have a look, thanks.

  0

  

  Eric Karugu•210

  @erickaruguPosted over 3 years ago

  @kamari-1 Okay, I think you have not pushed the updated code yet.

  0

  

  Clement•110

  @kamari-1Posted over 3 years ago

  @erickarugu32 Yeah, my bad. I've fixed it now though. Thanks.

  0
• 

  Ritesh Jangra•365

  @riteessshhPosted over 3 years ago

  Hey @kamari-1, Nice Work! border-top: 1px solid red; is the simplest way to style like this. Hope this will help.

  0

  ---

  

  Clement•110

  @kamari-1Posted over 3 years ago

  @riteessshh yes, but doesn't work for linear-gradient. Also had a hard time using linear-gradient with hsl.

  Please how does my live site look on your end? my styling seems to have broken after uploading to github.

  0

  

  Ritesh Jangra•365

  @riteessshhPosted over 3 years ago

  @kamari-1 yes for that gradient border, I also used div. And don't worry your styling is great. You did well.

  0

  

  Clement•110

  @kamari-1Posted over 3 years ago

  @riteessshh Okay. Thanks.

  0