Social media dashboard with grid, flex, CSS & js
Design comparison
Solution retrospective
In the dark mode input, I get a warning, but I don't know what error it has, also if you could advise me a way to write cleaner JavaScript, I would appreciate it.
Community feedback
- @tesla-ambassadorPosted over 3 years ago
Hey @JorgeDevJ. I really love the work you have done with the site and I personally think that you did a great job! The only thing I can say is try not to use I.D's in some instances to avoid HTML issues and I'd recommend you to use classes instead in that you don't have to use them uniquely. Also you could add labels to your form elements for easy accessibility by those that may have a few visual impairments and may require assistance from a screen reader.
Marked as helpful2@palgrammingPosted over 3 years ago@tesla-ambassador
I.D's in some instances to avoid HTML issues
To avoid what issues?0@koikiss-devPosted over 3 years ago@tesla-ambassador Hi, thanks for your answer; I really don't know if I've solved it yet but I've just made some adjustments with what I've been told.
0 - @benjoquilarioPosted over 3 years ago
Well done! Jorge Durón
The only thing I might suggest is to add a
max-width
to some of the sections on the page so that they don't become too wide on the content inside. I make it wide to1800px
and It's too wide.keep coding 🔥😊
Marked as helpful1@koikiss-devPosted over 3 years ago@benjoquilario thanks for that tip, I added that to the cards above.
0 - @jmnyaregaPosted over 3 years ago
Add some padding on the cards too.
Marked as helpful1 - @palgrammingPosted over 3 years ago
The main thing I see is that the user has to click the circle in the mode slider to change modes it would be nice if the user could click any place in the slider for it to change
Marked as helpful1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord