Social media dashboard: HTML, SCSS, JS

Community feedback

• 

  T

  Grace•31,270

  @grace-snowPosted almost 4 years ago

  Hey looks great on mobile, well done! Looks like there's something wrong with the grid on desktop from that preview though.

  To make your toggle accessible you're very close but not quite there. Either the words 'dark mode' need to be within the label element (recommended), or they need an ID adding and an aria-labelledby="THAT-ID" adding to the checkbox input.

  Hope that helps ☺

  1

  ---

  

  Olaleye Blessing•355

  @Olaleye-BlessingPosted almost 4 years ago

  @grace-snow Thanks for your advice. I've made the correction, 'dark mode' is now within the label element. I never thought of accessibility(I only heard a little about it when I started web dev) when I started the project. I could have tried the second method but to be honest, this is my first time of seeing aria-labelledby :). I guess aria-labelledby relates to accessibility. Thanks for your comment and you can check it out now in case I could improve on other things. Thanks

  1