@pikapikamart
Posted
Hey, good work on this one. The toggle works well no issue with it.
My suggestions would be that
-
Adding a
gap
in yourgroupcard
selector. Because right now, they are touching each cards which is not ideal. Are you working on a larger screen? Because it will be different in there compared to some, like me who have lower dimension than that. -
Resizing. When resizing, the viewports' width now hides the element of the
groupcard
selector which holds the top 4 cards. It will be better if you dedicate a specific layout for those in a breakpoint where the element get starts to be hidden. At around 900px going down to 600px. -
Javascript. The console is prompting an error every time I try to use the toggle button. Upon looking your javascript. There is a function call
out()
which is not declared. I think you should useoutToggleText()
because that is the one that you declared. Also add semicolons;
in your ending statements.
Mobile state is good, nothing wrong it. But make sure to address to some above. Still, you did a good job^
@DanarGdg
Posted
@pikamart I am working on a larger screen, so I don't know it will be no gap on that card. in javascript, i forget to change out() function to outToggleText() and add semicolon. Thank you for the feedback. I appreciate that :)