Social media card using flex-box

Community feedback

• 

  Boris•2,870

  @mkborisPosted 3 months ago

  Nice work dev-italoregis, here are a few things to review

  • Using the a tag for the social links is sufficient, you don't need to wrap them in button tags. Also, using an unordered list ul to group them is a better approach for both semantics and accessibility.
  • It's best practice linking Google fonts directly in the HTML head section rather than directly in your CSS file as it enables asynchronous downloading, improving page load times.
  • Consider using a modern CSS reset at the start of the styles in every project. Like this one Modern CSS Reset. This will help reset a list of default browser styles.

  2

  ---

  

  Italo Régis•40

  @dev-italoregisPosted 3 months ago

  @mkboris 

  Thanks a lot, Boris. 

  • I just used the button  because I couldn't make it work my div a with cursor: pointer;, don't know why, though. But I preferred using buttons. 
  • Thanks for the tips; every course or video that I saw until today explains me this way.
  • I have a question about your modern reset. I always have "problems" with margin and padding that the browser uses; I couldn't see the reset of padding anywhere. Can you explain to me why?

  0