Skip to content
Submitted about 2 months ago

social media

malak-ehab•30
@malak-ehab
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Social links profile
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Community feedback

  • ldonnianni•130
    @ldonnianniPosted about 2 months ago

    Great job! I would like to share some advice that someone recently gave me that it might help refinining some stuff.

    Using a <main> tag inside the <body> of your HTML is a best practice because it clearly identifies the main content of your page. This helps with accessibility and improves how search engines understand your content.

    For this challenge I used 2 containers, 1 for the users name and data, and a second one for the list of socials. It gave me at least more accurecy when I set the layout of the page, and to set the gap between elements.

    For this challenge, I used also buttons at first and someone suggest me this (I change it and it works perfect)

    Put these into a <ul> <li>, and the text should be wrapped with a <a> so it is accessible with a keyboard using the tab key, Using an <a> tag for navigation is semantically correct, improves accessibility for screen readers, and ensures consistent behavior across browsers, unlike a <button> or a <div> not intended for links.

    @Stroudy also gave me this tip in regards of reseting the css Using a full modern CSS reset is beneficial because it removes default browser styling, creating a consistent starting point for your design across all browsers. It helps avoid unexpected layout issues and makes your styles more predictable, ensuring a uniform appearance on different devices and platforms, check out this site for a https://www.joshwcomeau.com/css/custom-css-reset/

    Hope this helps you too

    1
    Steven Stroud•11,910
    @StroudyPosted about 2 months ago

    Hey @ldonnianni, Nice bro! Giving feedback is apart of the learning journey! Lets go! 💪

    0
  • Steven Stroud•11,910
    @StroudyPosted about 2 months ago

    Amazing job with this! You’re making fantastic progress. Here are some small tweaks that might take your solution to the next level…

    • Using a <main> tag inside the <body> of your HTML is a best practice because it clearly identifies the main content of your page. This helps with accessibility and improves how search engines understand your content.

    • I think you could benefit from a plugin on VS code called Prettier, It will format your code make it more easily readable.

    • I would put these into a <ul> <li>, and the text should be wrapped with a <a> so it is accessible with a keyboard using the tab key, Using an <a> tag for navigation is semantically correct, improves accessibility for screen readers, and ensures consistent behavior across browsers, unlike a <button> or a <div> not intended for links.

      <a href="https://github.com/malak-ehab"><button> GitHub</button></a>
  <a href="https://www.frontendmentor.io/profile/malak-ehab"><button>Frontend Mentor</button></a> 
  <a href="https://www.linkedin.com/in/malak-elaktash-7a5323317?utm_source=share&utm_campaign=share_via&utm_content=profile&utm_medium=ios_app"><button>LinkedIn</button></a>
  <a href="https://www.facebook.com/kokyy.ehab/"><button>Facebook</button></a>
  <a href="https://www.instagram.com/malak_ehab07/?hl=en"><button>Instagram</button></a>

    • Using a full modern CSS reset is beneficial because it removes default browser styling, creating a consistent starting point for your design across all browsers. It helps avoid unexpected layout issues and makes your styles more predictable, ensuring a uniform appearance on different devices and platforms, check out this site for a Full modern reset

    • While px is useful for precise, fixed sizing, such as border-width, border-radius, inline-padding, and <img> sizes, it has limitations. Pixels don't scale well with user settings or adapt to different devices, which can negatively impact accessibility and responsiveness. For example, using px for font sizes can make text harder to read on some screens, Check this article why font-size must NEVER be in pixels. In contrast, relative units like rem and adjust based on the user’s preferences and device settings, making your design more flexible and accessible. Use px where exact sizing is needed, but prefer relative units for scalable layouts. If you want a deeper explanation watch this video by Kevin Powell CSS em and rem explained. Another great resource I found useful is this px to rem converter based on the default font-size of 16 pixel.

    You’re doing fantastic! I hope these tips help you as you continue your coding journey. Stay curious and keep experimenting—every challenge is an opportunity to learn. Have fun, and keep coding with confidence! 🌟

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord