Design comparison
SolutionDesign
Community feedback
- @Code-BeakerPosted about 1 month ago
Hi ๐ Good job completing the challenge. I want to share some of my suggestions for improving your solution.
- Use colors with good contrast to make it readable. The links are not clearly readable because it's black inside grey.
- You don't need to use all that unnecessary JavaScript in this project. Simply use the
<a
tag to create all those links. Something like this:
<ul> <li><a href="#">GitHub</a></li> <li><a href="#">Twitter</a></li> ... </ul>
- You could minimize the use of
br
tags by using adisplay: flex
on theul
element and adding agap: 1rem
. - There's a typo in the project title: "Social medai" -> media
- Make sure heading tags decrease one by one.
h1 h2 h3 ... ...
This is essential for the accessibility of the website.
- Instead of
px
, you can use eitherrem
orem
to make responsive layouts easier for you. - Use class selectors instead of tag selectors. Tag selection can mess up your code when you're dealing with large projects.
- Use CSS Variables or Custom properties to make your CSS reusable.
I hope this helps you learn something new! ๐ค
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord