Social links profile

Community feedback

• 

  JuanBachurDEV•40

  @JuanBachurDEVPosted about 2 months ago

  The results looks like very good, congratulations! I suggest about the semantic HTML, change <div></div> for <section></section> inside the card for separating the profile and links

  0
• 

  P

  Steven Stroud•11,890

  @StroudyPosted about 2 months ago

  Great work on this! You should be proud of how far you've come. Here are a few observations that might help you improve further…

  • What you have here is to many tags and is confusing, You have wrapped this text in a <p>, <button> and a <a>, You can safely remove the <p> here,

  <div>
    <p><button><a href="http://github.com/Joytreats">Github</button></a></p>
    <p><button><a href="http://www.frontendmentor.io/profile/Joytreats">Frontend Mentor</button></a></p>
    <p><button><a href="http://www.linkedin.com/in/joydavidemem">LinkedIn</button></a></p>
    <p><button><a href="http://x.com/Joys_Treats">Twitter</button></a></p>
    <p><button><a href="http://www.instagram.com/thejoydavid_techride">Instagram</button></a></p>
  </div>
  

  • Ideally it would be best to put these into a list like this,

   <ul>
        <li><a>GitHub</a></li>
        <li><a>Frontend Mentor</a></li>
        <li><a>LinkedIn</a></li>
        <li><a>Twitter</a></li>
        <li><a>Instagram</a></li>
      </ul>
  

  • Using max-width: 100% or min-width: 100% is more responsive than just width: 100% because they allow elements to adjust better to different screen sizes. To learn more, check out this article: responsive-meaning.
  • Developers should avoid using pixels (px) because they are a fixed size and don't scale well on different devices. Instead, use rem or em, which are relative units that adjust based on user settings, making your design more flexible, responsive, and accessible. For more information check out this, Why font-size must NEVER be in pixels or this video by Kevin Powell CSS em and rem explained.- Another great resource for px to rem converter.

  You’re doing fantastic! I hope these tips help you as you continue your coding journey. Stay curious and keep experimenting—every challenge is an opportunity to learn. Have fun, and keep coding with confidence! 🌟

  0