Design comparison
SolutionDesign
Solution retrospective
What are you most proud of, and what would you do differently next time?
I feel I did a good job. However, there is always room for improvement
What challenges did you encounter, and how did you overcome them?For the most part, it was easy to implement. I did almost forget to make the buttons active
What specific areas of your project would you like help with?Im pretty happy with it but any advice is welcome
Community feedback
- @Adhi-S12Posted 6 months ago
You component looks good, here are a few improvements you could make:
- You set height:70% on your .main class which breaks the application on desktop size.
- Also a general tip, never use
height:100vh
, always try to usemin-height:100vh
. - Also try not to explicitly set height to any items, heights should always be determined by the contents within the element.
- Since the social links are used to take us to other site, it is better to use anchor tag instead of a button. Also it is a list of social links, so the better structure would be
<ul><li><a href="">Github</a>...</li></ul>
- You used a div with class button and text inside for each links, you try to apply
font-weight: bold
but it is not applied because you are trying to apply font-weight property to a div element which does not work, if you had used something like<p>
or<a>
element, it would have worked. - Instead of making the card 100vh, try applying display: flex; justify-content: center; align-items: center`. This will center the card so that you don't have to set the height manually. Height will increase as you give padding and margin to elements inside.
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord