Design comparison
Community feedback
- @Alex-Archer-IPosted 4 months ago
Hi!
Cool work, your code is clean and good readable =)
You only forgot about
ul
andli
tags. It important semantic tags, and it's better to use it when encounter some kind of list. Something like this:<ul> <li><a href="#">It's a link here.</a></li> ...more links here </ul>
Good luck and keep doing =)
Marked as helpful1@OlewyPosted 4 months ago@Alex-Archer-I thank you so much for your helpful comment :)
I will definitely use lists now more often!
Would you say it's also better to use button tags inside of links or instead of links?
1@Alex-Archer-IPosted 4 months ago@Olewy
No, you did it right. Those are links, so the
a
tag is enough, even if they are looks like buttons. HTML is about meaning, not appearance =)Oh, and I forgot to tell you that every page should contain
main
tag. In simple projects like this it could be the container itself.1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord