Social Links Website using HTML and CSS

Community feedback

• 

  Dylan de Bruijn•3,230

  @DylandeBruijnPosted 5 months ago

  Hi @mattgo327,

  Great job on finishing this project. I'm trying to view your code but the link goes to your QR code solution.

  Some friendly constructive feedback:

  • You could try to make your solution look more like the design. At the moment the buttons appear too big and the correct font-family is not being used.

  • Because you use percentages to set the height and width of your card the look of your card changes when viewing it on different viewports. I suggest you use px, em or rem values. The height of the card can be untouched, it's common practice to let the content control the height of the element.

  • Try using a tags for your links instead of a button. There are use cases for both of them, but in this example you want the links to actually navigate to something else. Using a tags for this behaviour is standard. You can always style them to look like a button, but under the hood it's a link.

  I hope you find my feedback helpful and if you have any other questions ask away!

  Marked as helpful

  1

  ---

  

  mattgo327•110

  @mattgo327Posted 5 months ago

  @DylandeBruijn Hey Dylan, thanks for the feedback. Yeah,about the height of the buttons, when I was working on those I didn't the real height in my developer gadget, I use Brave. I don't know if that's why I didn't look how it really looked or beacuse I used percentages. Anyway, thank you for the support.

  0

  

  Dylan de Bruijn•3,230

  @DylandeBruijnPosted 5 months ago

  @mattgo327

  No problem, I would appreciate it if you could mark my comment as helpful if it did help you out!

  0

  

  mattgo327•110

  @mattgo327Posted 5 months ago

  @DylandeBruijn I put the code now in the main branch, you can check it out.

  1